Eager load improvements for post lists#1811
Merged
Conversation
…h to avoid N+1 queries
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Oaphi
commented
Aug 28, 2025
|
|
||
| # eager loading revived collections' used relation to prevent N+1 queries | ||
| @pinned_links = @pinned_links.list_includes | ||
| @hot_questions = @hot_questions.list_includes |
Member
Author
There was a problem hiding this comment.
Eager loading is done in this manner here to facilitate eager loading of collections received from cache.
ArtOfCode-
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures we eager load associations used in post lists to avoid N+1 queries when loading category post lists. In particular, it significantly reduces the amount of queries made by
generic_share_link(that needscommunity) and category tag ids getters (that need respective tags).