Skip to content

Fix hints width on the last step of the tour#1818

Merged
Oaphi merged 32 commits intodevelopfrom
0valt/tour-fixes
Sep 5, 2025
Merged

Fix hints width on the last step of the tour#1818
Oaphi merged 32 commits intodevelopfrom
0valt/tour-fixes

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Sep 3, 2025

closes #247 with a hammer this time

The PR also significantly reworks question 3 of the tour to make it work smoothly on narrow screens:

ssr-2025-09-04_07.36.43.mp4

@Oaphi Oaphi self-assigned this Sep 3, 2025
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.25%. Comparing base (c86515b) to head (4726c79).
⚠️ Report is 52 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 70.87% <ø> (ø)
helpers 81.96% <ø> (ø)
jobs 60.00% <ø> (ø)
models 88.36% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Oaphi added 26 commits September 4, 2025 04:16
@Oaphi Oaphi requested review from a team, cellio and trichoplax September 4, 2025 04:52
@Oaphi Oaphi marked this pull request as ready for review September 4, 2025 04:58
@Oaphi Oaphi requested a review from ArtOfCode- September 4, 2025 04:58
Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested in a small window. Code looks good to me but you should have someone else look especially at JS and CSS.

Already mentioned by someone else in chat, but let's fix that "sidebar" reference in the first panel while we're at it.

Copy link
Member

@ArtOfCode- ArtOfCode- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for code changes

@Oaphi Oaphi merged commit 5c83ab9 into develop Sep 5, 2025
13 checks passed
@Oaphi Oaphi deleted the 0valt/tour-fixes branch September 5, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tour is too squished to be readable on phones

3 participants