Assorted fixes for errors

app/models/post.rb

@@ -187,6 +187,12 @@ def closeable?
     post_type.is_closeable
   end
 
+  # Is the post deleted by the owner?
+  # @return [Boolean] check result
+  def deleted_by_owner?
+    deleted_by&.same_as?(user)
+  end
+
   # @return [Boolean] whether there is a suggested edit pending for this post
   def pending_suggested_edit?
     SuggestedEdit.where(post_id: id, active: true).any?

app/views/posts/_expanded.html.erb

@@ -131,24 +131,23 @@
         </div>
       <% end %>
 
-      <% if post.deleted %>
+      <% if post.deleted? %>
         <div class="notice has-margin-2">
           <p class="has-font-weight-normal">
             <strong>Deleted</strong> by <%= user_link post.deleted_by %>
             on <%= post.deleted_at.strftime('%b %e, %Y at %H:%M') %>
           </p>
           <hr>
-          <% if post.deleted_by.id == post.user_id %>
+          <% if post.deleted_by_owner? %>
             <p>
-              The author of this post decided to delete it. It can only be seen by users with the Curate privilege.
+              The author of this post decided to delete it. It can only be seen by users with the Curate ability.
             </p>
           <% else %>
             <p>
-              This post was deleted and can only be seen by users with the Curate privilege.
+              This post was deleted and can only be seen by users with the Curate ability.
             </p>
           <% end %>
-
-          <p>Users with the Curate privilege may vote to restore this post if it has been deleted incorrectly.</p>
+          <p>Users with the Curate ability may vote to restore this post if it has been deleted incorrectly.</p>
         </div>
       <% end %>
 

app/views/reactions/_list.html.erb

@@ -22,6 +22,9 @@
     <% end %>
 </div>
 
+<%# TODO: eager load instead %>
+<% host = post.community.host %>
+
 <% post.reaction_list.each do |rt, rr| %>
     <div class="modal is-with-backdrop reaction-info-modal"
          id="reaction-info-<%= post.id %>-<%= rt.id %>">
@@ -43,9 +46,7 @@
                     </tr>
                     <% rr.each do |r| %>
                     <tr>
-                        <td>
-                            <%= link_to rtl_safe_username(r.user), user_path(r.user), dir: 'ltr'%>
-                        </td>
+                        <td><%= user_link(r.user, { host: host }) %></td>
                         <td class="comment-col">
                             <% if r.comment %>
                                 <div class="muted-p">

test/models/post_test.rb

@@ -130,4 +130,10 @@ class PostTest < ActiveSupport::TestCase
       end
     end
   end
+
+  test 'deleted_by_owner? should correctly determine if the post is deleted by its owner' do
+    posts.reject(&:deleted).each do |post|
+      assert_not post.deleted_by_owner?
+    end
+  end
 end