Skip to content
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/javascripts/character_count.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ $(() => {
} else if (gteThreshold) {
setCounterState($counter, 'warning');
setCounterIcon($icon, 'fa-exclamation-circle');
setInputValidationState($tgt, 'valid');
} else {
setCounterState($counter, 'default');
setCounterIcon($icon, 'fa-check');
Expand Down
14 changes: 7 additions & 7 deletions app/assets/javascripts/comments.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,24 +41,24 @@ $(() => {
window.hljs && hljs.highlightAll();
}

$(document).on('click', '.post--comments-thread.is-inline a', async (evt) => {
if (evt.ctrlKey) {
return; // TODO: do we need this early exit?
$(document).on('click', '.post--comments-thread.is-inline a', async (ev) => {
if (ev.ctrlKey || ev.metaKey) {
return;
}

evt.preventDefault();
ev.preventDefault();

const $tgt = $(evt.target);
const $tgt = $(ev.target);
const $threadId = $tgt.data('thread');
const wrapper = getCommentThreadWrapper($tgt);

openThread(wrapper, $threadId);
});

$(document).on('click', '.js-show-deleted-comments', (ev) => {
if (ev.ctrlKey) {
if (ev.ctrlKey || ev.metaKey) {
return;
} // do we really need it?
}

ev.preventDefault();

Expand Down
Loading