Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArtOfCode-
requested changes
Sep 13, 2025
ArtOfCode-
approved these changes
Sep 13, 2025
cellio
approved these changes
Sep 14, 2025
Member
cellio
left a comment
There was a problem hiding this comment.
Tested and notifications showed up promptly in my dev environment, for what that's worth. I see that Art has already reviewed the code, so LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures fixes caching behavior for user notifications (currently, in production we allow those to get cached for a day with no regard to new notifications). It also makes it possible to test response caching in development as it turns out Rack::MiniProfiler overwrites cache control headers even if
perform_cachingis set totrue. Finally, it also fixes aDoubleRenderErrorwhen requestingthread_contenttwice in a row (that's not in production yet, I made a mistake when addingfresh_whenwithrespond_to).