Remove extremely high z-index for Select2 containers causing them to render over modal backgrounds#1854
Merged
Remove extremely high z-index for Select2 containers causing them to render over modal backgrounds#1854
Conversation
Oaphi
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArtOfCode-
approved these changes
Sep 28, 2025
cellio
approved these changes
Sep 28, 2025
Member
cellio
left a comment
cellio
left a comment
There was a problem hiding this comment.
LGTM. Tested image upload per the issue and checked a few other modals (flag, close, tools, notifications). Everything looks fine.
Member
Author
|
Note to self: check mobile header dropdowns before merge |
Oaphi
force-pushed
the
0valt/z-index
branch
from
59e48c9 to
4a59bae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1546
This is necessary -
z-indexneeds to be added only when there is no other way, not the other way around, otherwise it always ends up in issues like this one (not to mention that Select2 already controls the property for its dropdowns, there's no need to interfere with it). I've checked what I could - do let me know ifz-indexnow needs to be slightly increased in some places to avoid overlapping.