Skip to content

Seeds should not skip creation of initial posts if UPDATE_POSTS is not set or false#1858

Merged
Oaphi merged 1 commit intodevelopfrom
0valt/seed
Sep 30, 2025
Merged

Seeds should not skip creation of initial posts if UPDATE_POSTS is not set or false#1858
Oaphi merged 1 commit intodevelopfrom
0valt/seed

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Sep 30, 2025

As per discussion in Discord with an interested party: our post seeds actually don't even run if UPDATE_POSTS is not set or is false. This is definitely not intentional as the logic inside the handler accounts for the situation. This PR fixes that oversight

@Oaphi Oaphi added this to the v0.12.4 milestone Sep 30, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.24%. Comparing base (2e13957) to head (39c8af3).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 72.22% <ø> (ø)
helpers 82.43% <ø> (-0.53%) ⬇️
jobs 60.86% <ø> (ø)
models 89.19% <ø> (ø)
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi merged commit a131fa7 into develop Sep 30, 2025
13 checks passed
@Oaphi Oaphi deleted the 0valt/seed branch September 30, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants