Conversation
…_ratio test expectations - Replace hardcoded forward-slash paths with os.path.join() in test files - Fix test_win_rate assertions: all-winning trades correctly return inf, not 0.0 - Use existing OHLCV data files instead of downloading Closes #369
…in tests/domain (#371) - test_backtest.py: Replace hardcoded forward-slash path to non-existent backtest_data/ CSV with os.path.join to existing test_data/ohlcv/ file - test_polars.py: Update datetime64[ns] assertion to datetime64[us] for newer pandas compatibility - test_backtest_save.py: Fix test_save_without_metrics to assert metrics.json is NOT created when no pre-computed metrics are provided (matching actual BacktestRun.save() behavior)
…ltered_out tests in tests/infrastructure (#373) - Replace all f-string forward-slash path concatenation with os.path.join() in test_csv_ohlcv_data_provider.py (11 occurrences) - Skip 2 failing filtered_out metadata tests in test_backtest_service.py (framework does not currently set filtered_out flag when window filter removes a backtest)
…s-paths fix: Use existing OHLCV data files and make Windows path compatible in tests/domain (#371)
…s-paths-infrastructure fix: Windows-compatible paths in tests/infrastructure (#373)
This reverts commit 4809267.
Collaborator
Author
|
Closing in favor of a new release PR that excludes squad files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Issue Templates
Bug Fixes
os.path.join()(closes [Test Fix]: Use existing ohlcv data files and make windows path compatible #369)test_win_rateassertions to match correctget_win_loss_ratiobehaviorDependencies (merged Dependabot PRs)
Tests