Skip to content

Do not retry processing when there is no picture #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Do not retry processing when there is no picture #199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a3dbd6
Do not retry processing when there is no picture
amureki Feb 5, 2025
7c73c82
Don't retry on FileNotFound in celery, dramatiq
amureki Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pictures/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@
pass
else:

@dramatiq.actor(queue_name=conf.get_settings().QUEUE_NAME)
@dramatiq.actor(

Check warning on line 56 in pictures/tasks.py

View check run for this annotation

Codecov / codecov/patch

pictures/tasks.py#L56 

Added line #L56 was not covered by tests
queue_name=conf.get_settings().QUEUE_NAME, throws=(FileNotFoundError,)
)
def process_picture_with_dramatiq(
storage: tuple[str, list, dict],
file_name: str,
Expand Down Expand Up @@ -87,6 +89,7 @@
@shared_task(
ignore_results=True,
retry_backoff=True,
dont_autoretry_for=(FileNotFoundError,),
)
def process_picture_with_celery(
storage: tuple[str, list, dict],
Expand Down