Drop Prometheus middleware from dramatiq settings #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus client became optional in dramatiq: https://github.com/Bogdanp/dramatiq/releases/tag/v2.0.0 I think we don't need to cover all our dependencies's subdependencies, so it is fine to drop it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
============================================
+ Coverage 89.06% 100.00% +10.93%
============================================
Files 13 13
Lines 494 494
============================================
+ Hits 440 494 +54
+ Misses 54 0 -54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Copilot finished reviewing on behalf of
amureki
November 21, 2025 08:07
There was a problem hiding this comment.
Pull Request Overview
This PR removes the optional Prometheus middleware from the dramatiq broker configuration in test settings, following dramatiq v2.0.0's change that made Prometheus client an optional dependency.
Key Changes
- Removed
dramatiq.middleware.Prometheusfrom the DRAMATIQ_BROKER middleware list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus client became optional in dramatiq:
https://github.com/Bogdanp/dramatiq/releases/tag/v2.0.0
I think we don't need to cover all our dependencies's subdependencies, so it is fine to drop it.