Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 8 8
Lines 230 230
=======================================
Hits 223 223
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Python and Django version support by removing Django 5.0 and 5.1 in favor of Django 5.2 and 6.0, and adding Python 3.14 support. The changes also introduce exclusion rules in the CI matrix to avoid testing incompatible version combinations.
Key Changes:
- Adds Python 3.14 support and removes Django 5.0/5.1 in favor of Django 5.2/6.0
- Updates CI workflow to test new version combinations with appropriate exclusions
- Excludes Python 3.14 + Django 4.2 and Python 3.11 + Django 6.0 combinations from CI testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Updates Python and Django version classifiers to add 3.14, 5.2, and 6.0 while removing 5.0 and 5.1 |
| .github/workflows/ci.yml | Updates CI test matrix with new Python/Django versions and adds exclusion rules for incompatible combinations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - python-version: "3.11" | ||
| django-version: "6.0" |
There was a problem hiding this comment.
The exclusion of Python 3.14 with Django 4.2 is appropriate since Django 4.2 (released April 2023) predates Python 3.14 and is unlikely to officially support it. However, the exclusion of Python 3.11 with Django 6.0 should be verified. Django 6.0 may drop support for Python 3.11, but this should be confirmed against Django's official compatibility matrix before excluding this combination from testing.
| - python-version: "3.11" | |
| django-version: "6.0" |
| "Programming Language :: Python :: 3.14", | ||
| "Framework :: Django", | ||
| "Framework :: Django :: 4.2", | ||
| "Framework :: Django :: 5.0", | ||
| "Framework :: Django :: 5.1", | ||
| "Framework :: Django :: 5.2", | ||
| "Framework :: Django :: 6.0", |
There was a problem hiding this comment.
The pyproject.toml classifiers list both Python 3.14 and Django 4.2 as supported versions. While the CI workflow correctly excludes this incompatible combination, users looking only at PyPI classifiers may incorrectly assume Python 3.14 works with Django 4.2. Consider whether the classifiers should be more precise, or if additional documentation is needed to clarify the supported version combinations.
No description provided.