Skip to content

Fix #297 -- Add Django admin' inline formset support #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Fix #297 -- Add Django admin' inline formset support #300

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fb0ba65
Added the fix from the issue #249
mardukbp Sep 11, 2024
83052e3
Only delete the .select2-container if it contains a .django-select2
mardukbp Sep 16, 2024
3599159
Fixed formatting in oder to comply with standard JS style
mardukbp Sep 16, 2024
7c001d8
Update django_select2/static/django_select2/django_select2.js
mardukbp Nov 25, 2024
f9ed100
Call djangoSelect2 instead of djangoAdminSelect2
mardukbp Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions django_select2/static/django_select2/django_select2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,30 @@

$(function () {
$('.django-select2').djangoSelect2()

// This part fixes new inlines not having the correct select2 widgets
function handleFormsetAdded (row, formsetName) {
// Converting to the "normal jQuery"
const jqRow = $(row)

// Because select2 was already instantiated on the empty form, we need to remove it, destroy the instance,
// and re-instantiate it.
jqRow.find('.django-select2').parent().find('.select2-container').remove()
jqRow.find('.django-select2').djangoSelect2('destroy')
jqRow.find('.django-select2').djangoSelect2()
}

// See: https://docs.djangoproject.com/en/dev/ref/contrib/admin/javascript/#supporting-versions-of-django-older-than-4-1
$(document).on('formset:added', function (event, $row, formsetName) {
if (event.detail && event.detail.formsetName) {
// Django >= 4.1
handleFormsetAdded(event.target, event.detail.formsetName)
} else {
// Django < 4.1, use $row and formsetName
handleFormsetAdded($row.get(0), formsetName)
}
})
// End of fix
})

return $.fn.djangoSelect2
Expand Down