Skip to content

Conversation

@DanielGovrin
Copy link
Collaborator

This pr introduces the change of the _codux folder location to root dir to match the other templates.

Daniel Cohen added 3 commits September 24, 2024 10:39
- Update paths in tsconfig.json to include "~/src/*" for "~/*" alias
- Update import statements in various files to use "~/components" and "~/api" aliases instead of relative paths
Copy link

@matangeorgi matangeorgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved just please go over the comments

@@ -0,0 +1,11 @@
import { Footer } from '~/components/site-footer/site-footer';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to include this file addition in this PR?

@@ -0,0 +1,14 @@
import { Header } from '~/components/header/header';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one as well

import styles from './intro.module.scss';
import Classnames from 'classnames';
import CommonStyles_module from '../../../styles/common-styles.module.scss';
// import CommonStyles_module from '~/styles/common-styles.module.scss';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

"include": ["src", "_codux"],
"references": [{ "path": "./tsconfig.node.json" }]
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can delete those new lines :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants