-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: changing _codux folder location to root dir #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: changing _codux folder location to root dir #38
Conversation
- Update paths in tsconfig.json to include "~/src/*" for "~/*" alias - Update import statements in various files to use "~/components" and "~/api" aliases instead of relative paths
matangeorgi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved just please go over the comments
| @@ -0,0 +1,11 @@ | |||
| import { Footer } from '~/components/site-footer/site-footer'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to include this file addition in this PR?
| @@ -0,0 +1,14 @@ | |||
| import { Header } from '~/components/header/header'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one as well
| import styles from './intro.module.scss'; | ||
| import Classnames from 'classnames'; | ||
| import CommonStyles_module from '../../../styles/common-styles.module.scss'; | ||
| // import CommonStyles_module from '~/styles/common-styles.module.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
| "include": ["src", "_codux"], | ||
| "references": [{ "path": "./tsconfig.node.json" }] | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can delete those new lines :)
This pr introduces the change of the _codux folder location to root dir to match the other templates.