Skip to content

fix: Allow /sa/trust-zone-operator#95

Merged
jsnctl merged 2 commits intomainfrom
jsnctl/envoy-trust-zone-operator-path
Feb 12, 2026
Merged

fix: Allow /sa/trust-zone-operator#95
jsnctl merged 2 commits intomainfrom
jsnctl/envoy-trust-zone-operator-path

Conversation

@jsnctl
Copy link
Member

@jsnctl jsnctl commented Feb 12, 2026

For TZaaS, we need to allow the inbound connection from the trust-zone-operator to auth and initialise its client with its SPIFFE ID in this format

@jsnctl jsnctl added this to the now milestone Feb 12, 2026
@jsnctl jsnctl self-assigned this Feb 12, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @jsnctl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Envoy configuration within the cofide-connect Helm chart to allow the trust-zone-operator service to establish inbound connections. This is achieved by adding a new regular expression for the trust-zone-operator's SPIFFE ID, ensuring it can authenticate and initialize its client as required by the TZaaS environment.

Highlights

  • Envoy Configuration Update: Modified the Envoy configuration within the cofide-connect chart to include a new Service Account Name (SAN) URI matcher.
  • Trust-Zone-Operator Access: Enabled inbound connections for the trust-zone-operator service account by adding its specific SPIFFE ID regex to the allowed list for authentication.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • charts/cofide-connect/templates/configmap-envoy.yaml
    • Added a new safe_regex entry to the Envoy configuration to permit the SPIFFE ID for the trust-zone-operator service account.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Envoy configuration to allow inbound connections from the trust-zone-operator by adding its SPIFFE ID to the list of authorized identities. However, a high-severity vulnerability was identified: the regex used to validate the new service's SPIFFE ID is overly permissive, allowing any trust domain, which could lead to an authentication bypass. Additionally, the chart's flexibility could be improved by parameterizing the hardcoded namespace.

@jsnctl jsnctl enabled auto-merge (squash) February 12, 2026 13:56
@jsnctl jsnctl merged commit cf1ba8c into main Feb 12, 2026
1 check passed
@jsnctl jsnctl deleted the jsnctl/envoy-trust-zone-operator-path branch February 12, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants