Direct support for connect as a datasource for k8s psat node attestor

[alec-w]

Part of https://github.com/cofide/cofide/issues/175

Requires https://github.com/cofide/cofide-spire/pull/153

Enables using Cofide Connect as the datasource for the k8s psat plugin to be configured through the helm chart.

[gemini-code-assist]

Summary of Changes

Hello @alec-w, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the spire-server Helm chart by integrating a new connectK8sPSAT node attestor. This allows the SPIRE server to leverage a 'Connect' datasource for Kubernetes PSAT node attestation, making the feature easily configurable through the Helm chart. The changes are designed to work in conjunction with a related PR in the cofide-spire repository.

Highlights

• New Node Attestor Support: Introduced direct support for 'connect' as a datasource for the Kubernetes PSAT node attestor, enabling its configuration via the Helm chart.
• Helm Chart Configuration: Modified the spire-server Helm chart to include new configuration parameters for the connectK8sPSAT node attestor, such as enabled and pollInterval.
• Conditional Plugin Data: Updated the configmap.yaml to conditionally inject plugin_data_cofide_connect and plugin_data_cofide_connect_poll_interval when the connectK8sPSAT attestor is enabled.
• RBAC Role Extension: Extended the condition for creating the Kubernetes PSAT node attestor's ClusterRole to also apply when the connectK8sPSAT attestor is active.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• charts/spire/charts/spire-server/templates/configmap.yaml
  • Added conditional logic to configure the k8s_psat plugin with plugin_data_cofide_connect and plugin_data_cofide_connect_poll_interval when connectK8sPSAT is enabled.
• charts/spire/charts/spire-server/templates/roles.yaml
  • Modified the condition for creating the ClusterRole for the k8s PSAT node attestor to include connectK8sPSAT.enabled.
• charts/spire/charts/spire-server/values.yaml
  • Introduced a new connectK8sPSAT configuration block with enabled and pollInterval parameters.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for using Cofide Connect as a data source for the k8s PSAT node attestor. The changes involve adding a new configuration section in values.yaml, updating the configmap.yaml template to use this new configuration, and adjusting RBAC roles in roles.yaml.

My review focuses on improving the clarity of the new configuration and preventing potential misconfigurations. I've suggested making the new connectK8sPSAT feature mutually exclusive with the existing k8sPSAT and externalK8sPSAT configurations to avoid confusion and improve robustness. I've also pointed out a way to simplify a complex conditional statement in the Helm template.