feat: use Cofide SPIRE server v1.12.4-cofide.0

[markgoddard]

This change switches to use the Cofide SPIRE server instead of upstream, initially at version v1.12.4-cofide.0.

The image repository is set, but the registry is not. The registry must be requested from Cofide.

[gemini-code-assist]

Summary of Changes

Hello @markgoddard, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request transitions the deployment of the SPIRE server to utilize a custom Cofide-maintained version. It involves updating the Helm chart configurations to reflect the new application version and redirecting the image pull source to Cofide's private registry, ensuring that future deployments use the specified Cofide build of SPIRE.

Highlights

• SPIRE Server Version Update: The appVersion for both the main spire Helm chart and its spire-server sub-chart has been updated from 1.12.4 to 1.10.2-cofide.17. This aligns the charts with the specific Cofide SPIRE server version being adopted.
• Image Source Redirection: The SPIRE server image source has been reconfigured in charts/spire/charts/spire-server/values.yaml. The image.registry is now 010438484483.dkr.ecr.eu-west-1.amazonaws.com and the image.repository is cofide/spire-server, switching from the upstream ghcr.io/spiffe/spire-server.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the Helm chart to use a custom cofide/spire-server image from a private ECR registry. While the changes align with the PR's intent, I've identified a critical version compatibility issue between the SPIRE server and agent that could impact functionality. I've also included recommendations to improve the chart's clarity and maintainability.

[gemini-code-assist]

Setting the top-level chart's appVersion to 1.10.2-cofide.17 is potentially misleading, as it suggests the entire SPIRE stack is at this version. In reality, other key components like spire-agent are on different versions (e.g., 1.12.4).

This inconsistency can cause confusion about the deployed application's state and makes version tracking difficult. For better clarity and maintainability, please consider aligning all component versions to a consistent version from the cofide fork. If a mix of versions is unavoidable, this should be clearly documented in the chart's README.md.