[sketch] Refactor low level reader functions to avoid using WarpedVRT - #656
Draft
vincentsarago wants to merge 1 commit into
Draft
[sketch] Refactor low level reader functions to avoid using WarpedVRT#656vincentsarago wants to merge 1 commit into
vincentsarago wants to merge 1 commit into
Conversation
vincentsarago
force-pushed
the
issue654
branch
from
November 27, 2023 20:54
e5eff80 to
d1a0629
Compare
vincentsarago
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to remove the usage of WarpedVRT by doing the
inverseof the current methodCurrent
Proposed
Right now it kinda works but break when using WarpedVRT as input dataset 😓
Also this approach seems a bit slower