-
Notifications
You must be signed in to change notification settings - Fork 36
docs: update styleguide.md with some prose on testing #2423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lets try to get it to flag redundant tests automatically 🤞
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2423 +/- ##
==========================================
- Coverage 91.28% 91.27% -0.02%
==========================================
Files 192 192
Lines 26184 26184
==========================================
- Hits 23903 23899 -4
- Misses 2281 2285 +4 🚀 New features to boost your workflow:
|
| - Bugfixes should always include a test that would previously fail to | ||
| guarantee against regression. | ||
| - Counter-intuitively, for data classes in the SDK, testing their load/dump | ||
| methods should not be done as this is done automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely true, there are edge cases that the automated tests don't cover. For example if an attribute is a union of multiple types, it will just test one of them, so there you should probably have some manual tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, yes 😢 We should really prioritize running it without a fixed seed...
Lets try to get it to flag redundant tests automatically 🤞