-
Notifications
You must be signed in to change notification settings - Fork 36
fix: handle missing id in TimeSeriesID for broken subscription references #2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
sighol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
haakonvt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦄 Thanks for making a fix!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2426 +/- ##
=======================================
Coverage 48.83% 48.84%
=======================================
Files 191 191
Lines 26142 26149 +7
=======================================
+ Hits 12767 12773 +6
- Misses 13375 13376 +1
🚀 New features to boost your workflow:
|
603450c to
53d62b9
Compare
Invalidated by push of 53d62b9
|
🦄 |
Description
When a time series
external_idis changed or the time series is deleted, the/timeseries/subscriptions/membersAPI returns members without anidfield. The SDK was expectingidto always be present, causing a KeyError.This PR:
TimeSeriesID.idoptional to align with the API contractis_resolvedproperty to check if a reference points to an existing time seriesFixes #2418
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.