Skip to content

Conversation

@evertoncolling
Copy link
Contributor

@evertoncolling evertoncolling commented Dec 16, 2025

Description

When a time series external_id is changed or the time series is deleted, the /timeseries/subscriptions/members API returns members without an id field. The SDK was expecting id to always be present, causing a KeyError.

This PR:

  • Makes TimeSeriesID.id optional to align with the API contract
  • Adds is_resolved property to check if a reference points to an existing time series

Fixes #2418

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • The PR title follows the Conventional Commit spec.

@evertoncolling evertoncolling requested review from a team as code owners December 16, 2025 12:07
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

Copy link
Contributor

@sighol sighol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

haakonvt
haakonvt previously approved these changes Jan 13, 2026
Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄 Thanks for making a fix!

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.84%. Comparing base (7c6f363) to head (53d62b9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...te/client/data_classes/datapoints_subscriptions.py 71.42% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2426   +/-   ##
=======================================
  Coverage   48.83%   48.84%           
=======================================
  Files         191      191           
  Lines       26142    26149    +7     
=======================================
+ Hits        12767    12773    +6     
- Misses      13375    13376    +1     
Files with missing lines Coverage Δ
...te/client/data_classes/datapoints_subscriptions.py 33.05% <71.42%> (+3.31%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haakonvt haakonvt added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@haakonvt haakonvt added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@haakonvt
Copy link
Contributor

🦄

@haakonvt haakonvt added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@haakonvt haakonvt added this pull request to the merge queue Jan 13, 2026
Merged via the queue into master with commit 7ce839c Jan 13, 2026
18 checks passed
@haakonvt haakonvt deleted the fix-ts-subscription branch January 13, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DatapointsSubscriptionAPI fails when a subscribed TimeSeries changes external_id

4 participants