Handle case where input is a directory better#433
Merged
Conversation
If a user configures a directory and not a simple file as the state store location, the error message produced is not very easy to understand. On windows in particular, it results in a "permission denied" error. This adds a more descriptive error message
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 75.22% 75.25% +0.02%
==========================================
Files 42 42
Lines 3496 3499 +3
==========================================
+ Hits 2630 2633 +3
Misses 866 866
🚀 New features to boost your workflow:
|
mathialo
requested review from
a team and
dbrattli
and removed request for
a team
|
🦄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user configures a directory and not a simple file as the state store location, the error message produced is not very easy to understand. On windows in particular, it results in a "permission denied" error.
This adds a more descriptive error message