Skip to content

Improve fetching of application config in unstable#434

Merged
mathialo merged 2 commits intomasterfrom
config-retry
Mar 26, 2025
Merged

Improve fetching of application config in unstable#434
mathialo merged 2 commits intomasterfrom
config-retry

Conversation

@mathialo
Copy link
Copy Markdown
Contributor

If a config doesn't exist in the integrations api, don't fail but enter a retry loop (until canceled).

If a config doesn't exist in the integrations api, don't fail but enter
a retry loop (until canceled).
@mathialo mathialo requested a review from a team as a code owner March 18, 2025 08:09
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 76.19048% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (e46868f) to head (c0c620d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/extractorutils/unstable/core/runtime.py 74.28% 9 Missing ⚠️
...e/extractorutils/unstable/configuration/loaders.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   75.27%   77.32%   +2.04%     
==========================================
  Files          42       42              
  Lines        3499     3523      +24     
==========================================
+ Hits         2634     2724      +90     
+ Misses        865      799      -66     
Files with missing lines Coverage Δ
...e/extractorutils/unstable/configuration/loaders.py 51.76% <85.71%> (+15.51%) ⬆️
cognite/extractorutils/unstable/core/runtime.py 47.68% <74.28%> (+47.68%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathialo mathialo requested a review from a team March 25, 2025 13:03
@psalaberria002 psalaberria002 added the risk-review-ongoing Risk review is in progress label Mar 25, 2025
@psalaberria002 psalaberria002 self-assigned this Mar 25, 2025
Copy link
Copy Markdown
Contributor

@psalaberria002 psalaberria002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@psalaberria002 psalaberria002 removed the risk-review-ongoing Risk review is in progress label Mar 25, 2025
@mathialo mathialo merged commit 0f2aca9 into master Mar 26, 2025
6 checks passed
@mathialo mathialo deleted the config-retry branch March 26, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants