Skip to content

Define _PromServerConfig as a dataclass#438

Closed
nithinb wants to merge 1 commit intomasterfrom
DOG-5422-prometheus-server-db-extractor
Closed

Define _PromServerConfig as a dataclass#438
nithinb wants to merge 1 commit intomasterfrom
DOG-5422-prometheus-server-db-extractor

Conversation

@nithinb
Copy link
Copy Markdown
Contributor

@nithinb nithinb commented May 7, 2025

No description provided.

@nithinb nithinb self-assigned this May 7, 2025
@nithinb nithinb requested a review from a team as a code owner May 7, 2025 09:49
@nithinb
Copy link
Copy Markdown
Contributor Author

nithinb commented May 7, 2025

The tests on this will continue to fail but the change is unrelated to that. So I think it is still worth a review

@einarmo
Copy link
Copy Markdown
Contributor

einarmo commented May 7, 2025

#437 :)

@nithinb
Copy link
Copy Markdown
Contributor Author

nithinb commented May 7, 2025

#437 :)

didn't see this. Approved that!!

@nithinb nithinb closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants