Add CDM Timeseries Upload Queue#439
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
==========================================
+ Coverage 77.71% 77.99% +0.27%
==========================================
Files 42 42
Lines 3523 3613 +90
==========================================
+ Hits 2738 2818 +80
- Misses 785 795 +10
🚀 New features to boost your workflow:
|
mathialo
left a comment
There was a problem hiding this comment.
The generic approach is pretty nice!
Noe more nitpick, but this is shaping up quite well
rsjr
left a comment
There was a problem hiding this comment.
Looks good. However, I suggest adding two more integration test cases:
- A test case ingesting datapoints with status codes (similar to this)
- A non-happy path test case just to cover the behavior when ingesting datapoints with wrong type to an existing time series: the time series is numeric but you try to ingest string datapoints (or vice-versa).
@rsjr |
Add CDM Timeseries Upload Queue support for Timeseries Destination in DB Extractor.