Update connection config schema#444
Merged
cognite-bulldozer[bot] merged 19 commits intomasterfrom Jun 26, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
+ Coverage 77.99% 78.00% +0.01%
==========================================
Files 42 42
Lines 3613 3624 +11
==========================================
+ Hits 2818 2827 +9
- Misses 795 797 +2
🚀 New features to boost your workflow:
|
`SecretClient` does not accept `None`s as the `credential`. This is a type issue, that `mypy` only _sometimes_ catches. There is no reason the `credentials` should be a class variable, it's only ever used inside the `_init_client` method, so it's fine to move it to a local variable.
einarmo
reviewed
Jun 17, 2025
einarmo
approved these changes
Jun 20, 2025
Contributor
einarmo
left a comment
einarmo
left a comment
There was a problem hiding this comment.
I'm fine with these changes now.
toondaey
added
the
waiting-for-risk-review
rsjr
removed
the
waiting-for-risk-review
rsjr
reviewed
Jun 26, 2025
Contributor
rsjr
left a comment
rsjr
left a comment
There was a problem hiding this comment.
risk review ok
This is not released anywhere.
rsjr
added
the
waiting-for-team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to update the connection schema to this.