Skip to content

Update ruff linting#445

Merged
mathialo merged 12 commits intomasterfrom
ruff-rules
Jun 6, 2025
Merged

Update ruff linting#445
mathialo merged 12 commits intomasterfrom
ruff-rules

Conversation

@mathialo
Copy link
Copy Markdown
Contributor

@mathialo mathialo commented Jun 5, 2025

Update the version of ruff running in CICD (as it was quite old).

Adding a few rules we have started having on a lot of our other codebases, and do the necessary changes in the code to comply with these rules.

@mathialo mathialo requested a review from a team as a code owner June 5, 2025 12:18
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 77.47%. Comparing base (cb5f904) to head (987c1c0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/extractorutils/statestore/hashing.py 0.00% 4 Missing ⚠️
...e/extractorutils/unstable/configuration/loaders.py 60.00% 4 Missing ⚠️
cognite/extractorutils/base.py 25.00% 3 Missing ⚠️
cognite/extractorutils/unstable/core/runtime.py 50.00% 2 Missing ⚠️
cognite/extractorutils/configtools/elements.py 83.33% 1 Missing ⚠️
cognite/extractorutils/configtools/loaders.py 50.00% 1 Missing ⚠️
cognite/extractorutils/statestore/watermark.py 75.00% 1 Missing ⚠️
cognite/extractorutils/threading.py 50.00% 1 Missing ⚠️
cognite/extractorutils/uploader/time_series.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   77.34%   77.47%   +0.12%     
==========================================
  Files          42       42              
  Lines        3523     3511      -12     
==========================================
- Hits         2725     2720       -5     
+ Misses        798      791       -7     
Files with missing lines Coverage Δ
cognite/extractorutils/configtools/__init__.py 100.00% <ø> (ø)
cognite/extractorutils/configtools/validators.py 72.72% <100.00%> (ø)
cognite/extractorutils/statestore/__init__.py 100.00% <ø> (ø)
...te/extractorutils/unstable/configuration/models.py 84.90% <ø> (ø)
cognite/extractorutils/unstable/core/base.py 58.72% <100.00%> (ø)
...ite/extractorutils/unstable/core/restart_policy.py 84.61% <ø> (ø)
cognite/extractorutils/unstable/core/tasks.py 90.00% <100.00%> (ø)
...e/extractorutils/unstable/scheduling/_scheduler.py 94.73% <100.00%> (ø)
cognite/extractorutils/uploader/__init__.py 100.00% <ø> (ø)
cognite/extractorutils/uploader/assets.py 91.52% <100.00%> (ø)
... and 15 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathialo mathialo added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jun 6, 2025
Copy link
Copy Markdown

@larshagencognite larshagencognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@larshagencognite larshagencognite self-assigned this Jun 6, 2025
@larshagencognite larshagencognite added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Jun 6, 2025
@mathialo mathialo merged commit 914650e into master Jun 6, 2025
6 checks passed
@mathialo mathialo deleted the ruff-rules branch June 6, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants