Skip to content

Ability to change working directory in unstable module.#453

Merged
toondaey merged 11 commits intomasterfrom
set-working-directory/dog-5529
Jul 7, 2025
Merged

Ability to change working directory in unstable module.#453
toondaey merged 11 commits intomasterfrom
set-working-directory/dog-5529

Conversation

@toondaey
Copy link
Copy Markdown
Contributor

@toondaey toondaey commented Jul 2, 2025

This is a simple CLI option that allows users to set/change the working directory of extractors. Users will be able to use -c or --cwd flags to change/set working directory.

@toondaey toondaey requested a review from a team as a code owner July 2, 2025 13:01
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.88%. Comparing base (6a0a3f1) to head (08eaf06).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/extractorutils/unstable/core/runtime.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
- Coverage   78.96%   78.88%   -0.08%     
==========================================
  Files          42       42              
  Lines        3636     3647      +11     
==========================================
+ Hits         2871     2877       +6     
- Misses        765      770       +5     
Files with missing lines Coverage Δ
cognite/extractorutils/unstable/core/runtime.py 47.85% <54.54%> (+0.48%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

devendra-lohar
devendra-lohar previously approved these changes Jul 3, 2025
@toondaey toondaey added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jul 3, 2025
andersfylling
andersfylling previously approved these changes Jul 3, 2025
Copy link
Copy Markdown

@andersfylling andersfylling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@andersfylling andersfylling self-assigned this Jul 3, 2025
@andersfylling andersfylling added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Jul 3, 2025
@toondaey toondaey dismissed stale reviews from andersfylling and devendra-lohar via f36d000 July 4, 2025 06:36
@toondaey toondaey added waiting-for-risk-review Waiting for a member of the risk review team to take an action and removed waiting-for-team Waiting for the submitter or reviewer of the PR to take an action labels Jul 4, 2025
devendra-lohar
devendra-lohar previously approved these changes Jul 4, 2025
@rsjr rsjr assigned rsjr and unassigned andersfylling Jul 4, 2025
Copy link
Copy Markdown
Contributor

@rsjr rsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

risk review ok

@rsjr rsjr added waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Jul 4, 2025
@toondaey toondaey requested review from devendra-lohar and rsjr July 7, 2025 07:36
@toondaey toondaey added waiting-for-risk-review Waiting for a member of the risk review team to take an action and removed waiting-for-team Waiting for the submitter or reviewer of the PR to take an action labels Jul 7, 2025
@toondaey toondaey requested a review from devendra-lohar July 7, 2025 08:16
Copy link
Copy Markdown
Contributor

@devendra-lohar devendra-lohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@rsjr rsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

risk review ok

@toondaey toondaey merged commit 753a751 into master Jul 7, 2025
6 checks passed
@toondaey toondaey deleted the set-working-directory/dog-5529 branch July 7, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-risk-review Waiting for a member of the risk review team to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants