You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
nice to set it to UTC! Have had a ton of problems correlating when the customer has some funky timezones in use when running on their systems. Very confusing.
risk review ok -- it will be good to report this in the future, indeed. Today, it is quite hard to detect extractors that end up in crash-looping (we've had that with the petrel studio connector for example -- although that is a very different type of beast that isn't in Python it taught me the need for this).
risk review ok -- it will be good to report this in the future, indeed. Today, it is quite hard to detect extractors that end up in crash-looping (we've had that with the petrel studio connector for example -- although that is a very different type of beast that isn't in Python it taught me the need for this).
This was discovered as a drawback of the previous extractors. There's a follow up PR coming soon to include this when the extractor reports a startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simply does nothing right now but just set the start time of the extractor. This will be used for one, when we report the startup.