Skip to content

fix bug in change working directory impl#459

Merged
toondaey merged 5 commits intomasterfrom
fix-change-working-director-bug
Jul 17, 2025
Merged

fix bug in change working directory impl#459
toondaey merged 5 commits intomasterfrom
fix-change-working-director-bug

Conversation

@toondaey
Copy link
Copy Markdown
Contributor

There was an issue where if this argument is not provided, it crashes the extractor. This fixes it.

@toondaey toondaey requested a review from a team as a code owner July 16, 2025 11:38
ozangoktan
ozangoktan previously approved these changes Jul 16, 2025
@toondaey toondaey added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jul 16, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.04%. Comparing base (015ce8a) to head (c8ed47d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/extractorutils/unstable/core/runtime.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   78.93%   79.04%   +0.10%     
==========================================
  Files          42       42              
  Lines        3650     3650              
==========================================
+ Hits         2881     2885       +4     
+ Misses        769      765       -4     
Files with missing lines Coverage Δ
cognite/extractorutils/unstable/core/runtime.py 50.30% <57.14%> (+2.45%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toondaey toondaey removed the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jul 16, 2025
@toondaey toondaey requested a review from ozangoktan July 17, 2025 05:22
@toondaey toondaey requested a review from ozangoktan July 17, 2025 08:19
@toondaey toondaey added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Jul 17, 2025
Copy link
Copy Markdown
Contributor

@rsjr rsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

risk review ok
Fixing a bug in a non-released feature

@rsjr rsjr added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Jul 17, 2025
@rsjr rsjr self-assigned this Jul 17, 2025
@toondaey toondaey merged commit d86b5ed into master Jul 17, 2025
6 checks passed
@toondaey toondaey deleted the fix-change-working-director-bug branch July 17, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants