Conversation
|
Doesn't the new unstable config use pydantic? I don't think this will work. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 80.67% 80.59% -0.09%
==========================================
Files 43 43
Lines 4124 4194 +70
==========================================
+ Hits 3327 3380 +53
- Misses 797 814 +17
🚀 New features to boost your workflow:
|
Make changes according to pydantic. |
…s into DOG-5997-replicate-config
…s into DOG-5997-replicate-config
einarmo
left a comment
There was a problem hiding this comment.
Could you add tests for using a pydantic field as well? I.e. that having a default works as expected. Also, could you write a test that verifies the equality logic? I.e. FileSizeConfig("2000MB") == FileSizeConfig("2GB")
Added more test cases to check the defaults and equality logic. |
einarmo
left a comment
There was a problem hiding this comment.
As a final note, you should mention in the PR description that this migrates an existing class to use pydantic, and link to the original config type.
This PR moves the
FileSizeConfigto the unstable configuration.Remaining config are already moved to unstable with Statestore and Metrics PR.