Skip to content

Allow log levels from lowercase#482

Merged
cognite-bulldozer[bot] merged 6 commits intomasterfrom
allow-log-level-from-lower-cases
Sep 22, 2025
Merged

Allow log levels from lowercase#482
cognite-bulldozer[bot] merged 6 commits intomasterfrom
allow-log-level-from-lower-cases

Conversation

@toondaey
Copy link
Copy Markdown
Contributor

Encountered this while testing and discovered that log levels can only be set with all caps. From experience, most users will usually prefer lower cases hence this change.

@toondaey toondaey requested a review from a team as a code owner September 17, 2025 15:15
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.47%. Comparing base (69ec438) to head (d39349f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...te/extractorutils/unstable/configuration/models.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   80.46%   80.47%   +0.01%     
==========================================
  Files          43       43              
  Lines        4038     4046       +8     
==========================================
+ Hits         3249     3256       +7     
- Misses        789      790       +1     
Files with missing lines Coverage Δ
...te/extractorutils/unstable/configuration/models.py 84.21% <87.50%> (+0.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toondaey toondaey added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Sep 19, 2025
@thorkildcognite thorkildcognite self-assigned this Sep 22, 2025
@thorkildcognite thorkildcognite added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Sep 22, 2025
@thorkildcognite
Copy link
Copy Markdown
Contributor

risk review ok

@cognite-bulldozer cognite-bulldozer bot merged commit fc5aedb into master Sep 22, 2025
6 checks passed
@cognite-bulldozer cognite-bulldozer bot deleted the allow-log-level-from-lower-cases branch September 22, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge auto-update risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants