Update string datapoint constraints to be in line with API changes#486
Merged
ozangoktan merged 1 commit intomasterfrom Oct 28, 2025
Merged
Update string datapoint constraints to be in line with API changes#486ozangoktan merged 1 commit intomasterfrom
ozangoktan merged 1 commit intomasterfrom
Conversation
88d0e11 to
eee8a0d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 80.59% 80.59%
=======================================
Files 43 43
Lines 4194 4194
=======================================
Hits 3380 3380
Misses 814 814
🚀 New features to boost your workflow:
|
Contributor
Author
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the string datapoint validation to align with recent API changes, switching from a character length limit to a UTF-8 byte limit. The version is bumped to 7.9.0 to reflect this change. The changes are consistently applied across the implementation, tests, version files, and changelog. The implementation correctly uses len(value.encode('utf-8')) for validation, and the tests have been updated to use the new constant and logic. The pull request appears to be correct and complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates string datapoint constraints to be in line with the recent changes to the API, where values are limited by UTF-8 bytes rather than string length. Also cuts a minor release.