Skip to content

Update string datapoint constraints to be in line with API changes#486

Merged
ozangoktan merged 1 commit intomasterfrom
string-dp-constraints-update
Oct 28, 2025
Merged

Update string datapoint constraints to be in line with API changes#486
ozangoktan merged 1 commit intomasterfrom
string-dp-constraints-update

Conversation

@ozangoktan
Copy link
Copy Markdown
Contributor

This PR updates string datapoint constraints to be in line with the recent changes to the API, where values are limited by UTF-8 bytes rather than string length. Also cuts a minor release.

@ozangoktan ozangoktan force-pushed the string-dp-constraints-update branch from 88d0e11 to eee8a0d Compare October 27, 2025 23:50
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.59%. Comparing base (6e8a485) to head (eee8a0d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   80.59%   80.59%           
=======================================
  Files          43       43           
  Lines        4194     4194           
=======================================
  Hits         3380     3380           
  Misses        814      814           
Files with missing lines Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
cognite/extractorutils/uploader/time_series.py 76.54% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ozangoktan
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the string datapoint validation to align with recent API changes, switching from a character length limit to a UTF-8 byte limit. The version is bumped to 7.9.0 to reflect this change. The changes are consistently applied across the implementation, tests, version files, and changelog. The implementation correctly uses len(value.encode('utf-8')) for validation, and the tests have been updated to use the new constant and logic. The pull request appears to be correct and complete.

@ozangoktan ozangoktan marked this pull request as ready for review October 28, 2025 00:01
@ozangoktan ozangoktan requested a review from a team as a code owner October 28, 2025 00:01
Copy link
Copy Markdown
Contributor

@einarmo einarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@ozangoktan ozangoktan merged commit 32cf066 into master Oct 28, 2025
6 checks passed
@ozangoktan ozangoktan deleted the string-dp-constraints-update branch October 28, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants