Remove extractor specific config from the base config#492
Conversation
Summary of ChangesHello @Hmnt39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the configuration model by extracting common dataset-related configuration into a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…s into hemant/config_changes
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the configuration model by extracting data set handling into a reusable WithDataSetId class and removing extractor-specific settings from the base ExtractorConfig. The changes improve modularity and clarify the configuration structure. However, I've found a critical issue where an obsolete test case was not removed, which will cause the build to fail. Please see the detailed comment.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 80.88% 80.89%
=======================================
Files 43 43
Lines 4201 4197 -4
=======================================
- Hits 3398 3395 -3
+ Misses 803 802 -1
🚀 New features to boost your workflow:
|
This PR refactors the configuration model to remove extractor specific config from the base configuration.
Mainly it introduces a new
WithDataSetIdbase class that can be inherited by any configuration model needing to reference CDF datasets. This class includes adata_setfield and aget_data_set()method to retrieve DataSet objects from CDF, making dataset configuration reusable across different parts of the codebase.Also, it removes the
retry_startup,upload_queue_sizefrom the base config.