Conversation
Summary of ChangesHello @Hmnt39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request officially releases version Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares for the 7.11.0 release by updating the version number in pyproject.toml and cognite/extractorutils/__init__.py, and adding a new entry to CHANGELOG.md. While the version bumps are correct, there appears to be a discrepancy between the code and the changelog. The changelog mentions the removal of extractor-specific configurations, but these configurations still seem to be present in the CogniteConfig class. This should be addressed to ensure the release notes are accurate.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
=======================================
Coverage 80.89% 80.89%
=======================================
Files 43 43
Lines 4197 4197
=======================================
Hits 3395 3395
Misses 802 802
🚀 New features to boost your workflow:
|
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| * Remove extractor specific config from the base config. |
There was a problem hiding this comment.
I think here, its worth elaborating on which particular parameters we removed, because its a fair expectation that Extractor-Utils would be used by other developers so they would need to know what changes they would have to make from their previous implementation to the new implementation
There was a problem hiding this comment.
It should also be mentioned that this is the unstable module.
There was a problem hiding this comment.
Changes done, mentioned for the unstable package
This PR releases the new version
7.11.0for python-extractor-utils.