Conversation
The Cognite SDK v8 is out, and is contains a few breaking changes (as is to be expected with a major release). We should of course migrate to the new version, but in the meantime, let's lock the version to <8 to avoid any issues for downstream users.
|
/gemini review |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses potential compatibility issues arising from the release of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly locks the cognite-sdk dependency to versions less than 8.0.0, preventing compatibility issues with the new major release. The version in pyproject.toml has been bumped to 7.11.6 and the CHANGELOG.md has been updated accordingly. However, as noted in the review comment, the __version__ attribute in cognite/extractorutils/__init__.py has not been updated, which could cause inconsistencies.
There was a problem hiding this comment.
Code Review
This pull request correctly locks the cognite-sdk dependency to versions below 8.0.0 to prevent issues with the new major release, and bumps the package version. However, there is a version inconsistency that needs to be addressed. The package version is updated in pyproject.toml, but not in cognite/extractorutils/__init__.py.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #508 +/- ##
=======================================
Coverage 81.22% 81.22%
=======================================
Files 43 43
Lines 4208 4208
=======================================
Hits 3418 3418
Misses 790 790
🚀 New features to boost your workflow:
|
The Cognite SDK v8 is out, and is contains a few breaking changes (as is
to be expected with a major release).
We should of course migrate to the new version, but in the meantime,
let's lock the version to <8 to avoid any issues for downstream users.