Skip to content

Lock SDK to <8#508

Merged
mathialo merged 2 commits intomasterfrom
lock-sdk
Mar 18, 2026
Merged

Lock SDK to <8#508
mathialo merged 2 commits intomasterfrom
lock-sdk

Conversation

@mathialo
Copy link
Copy Markdown
Contributor

The Cognite SDK v8 is out, and is contains a few breaking changes (as is
to be expected with a major release).

We should of course migrate to the new version, but in the meantime,
let's lock the version to <8 to avoid any issues for downstream users.

The Cognite SDK v8 is out, and is contains a few breaking changes (as is
to be expected with a major release).

We should of course migrate to the new version, but in the meantime,
let's lock the version to <8 to avoid any issues for downstream users.
@mathialo mathialo requested a review from a team as a code owner March 18, 2026 08:56
@mathialo
Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses potential compatibility issues arising from the release of Cognite SDK v8. To ensure stability for current users and prevent unexpected breaking changes, the cognite-sdk dependency has been explicitly constrained to versions below 8. This temporary measure allows for continued functionality while a comprehensive migration to the new SDK version can be planned and implemented in a future major release.

Highlights

  • Dependency Management: The cognite-sdk dependency has been explicitly locked to versions less than 8 (<8.0.0) to avoid breaking changes introduced in Cognite SDK v8.
  • Versioning: The project version in pyproject.toml has been incremented from 7.11.5 to 7.11.6.
  • Documentation: A new entry was added to CHANGELOG.md documenting the SDK version lock and the reason behind it.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly locks the cognite-sdk dependency to versions less than 8.0.0, preventing compatibility issues with the new major release. The version in pyproject.toml has been bumped to 7.11.6 and the CHANGELOG.md has been updated accordingly. However, as noted in the review comment, the __version__ attribute in cognite/extractorutils/__init__.py has not been updated, which could cause inconsistencies.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly locks the cognite-sdk dependency to versions below 8.0.0 to prevent issues with the new major release, and bumps the package version. However, there is a version inconsistency that needs to be addressed. The package version is updated in pyproject.toml, but not in cognite/extractorutils/__init__.py.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.22%. Comparing base (7187ddd) to head (32594a6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files          43       43           
  Lines        4208     4208           
=======================================
  Hits         3418     3418           
  Misses        790      790           
Files with missing lines Coverage Δ
cognite/extractorutils/__init__.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathialo mathialo added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Mar 18, 2026
Copy link
Copy Markdown

@sighol sighol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@sighol sighol self-assigned this Mar 18, 2026
@sighol sighol added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action and removed waiting-for-risk-review Waiting for a member of the risk review team to take an action labels Mar 18, 2026
@mathialo mathialo merged commit 7cef0c3 into master Mar 18, 2026
6 checks passed
@mathialo mathialo deleted the lock-sdk branch March 18, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants