Skip to content

Add config schemas for unstable module#510

Merged
einarmo merged 1 commit intomasterfrom
config-schemas
Mar 19, 2026
Merged

Add config schemas for unstable module#510
einarmo merged 1 commit intomasterfrom
config-schemas

Conversation

@einarmo
Copy link
Copy Markdown
Contributor

@einarmo einarmo commented Mar 19, 2026

These were missing. This also changes the state store config to match with our design guidelines for config structures.

@einarmo einarmo requested a review from a team as a code owner March 19, 2026 08:58
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the configuration and management of state stores within the unstable module. It introduces new configuration schemas, refactors the state store configuration, and streamlines the state store creation process. These changes aim to provide a more consistent and maintainable approach to state management in extractors.

Highlights

  • State Store Configuration: The PR introduces a new, more structured approach to configuring state stores, aligning with established design guidelines.
  • Configuration Schemas: The PR adds missing configuration schemas for the unstable module, enhancing clarity and maintainability.
  • State Store Creation: The PR modifies the state store creation logic to use a single function, simplifying the process and reducing redundancy.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good step forward, refactoring the state store configuration to use Pydantic's discriminated unions and adding JSON schemas for validation. The refactoring in the Python code is well-done and improves the configuration structure. My review focuses on the newly added JSON schema files, where I've found a few inconsistencies with JSON Schema standards and project conventions that should be addressed to ensure correctness.

These were missing. This also changes the state store config to match
with our design guidelines for config structures.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.27%. Comparing base (7cef0c3) to head (95a24ad).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...te/extractorutils/unstable/configuration/models.py 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
+ Coverage   81.22%   81.27%   +0.05%     
==========================================
  Files          43       43              
  Lines        4208     4204       -4     
==========================================
- Hits         3418     3417       -1     
+ Misses        790      787       -3     
Files with missing lines Coverage Δ
cognite/extractorutils/unstable/core/base.py 79.62% <100.00%> (+0.08%) ⬆️
...te/extractorutils/unstable/configuration/models.py 84.85% <80.00%> (+0.57%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@einarmo
Copy link
Copy Markdown
Contributor Author

einarmo commented Mar 19, 2026

🦄

@einarmo einarmo merged commit 9a91449 into master Mar 19, 2026
6 checks passed
@einarmo einarmo deleted the config-schemas branch March 19, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants