chore(webpack): add GLSL import tracker loader to track import dependencies in --watch mode #5437
Open
Strepto wants to merge 2 commits intocognitedata:masterfrom
Open
chore(webpack): add GLSL import tracker loader to track import dependencies in --watch mode #5437Strepto wants to merge 2 commits intocognitedata:masterfrom
Strepto wants to merge 2 commits intocognitedata:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5437 +/- ##
==========================================
+ Coverage 70.62% 70.65% +0.03%
==========================================
Files 1222 1224 +2
Lines 84723 84904 +181
Branches 9012 9031 +19
==========================================
+ Hits 59833 59988 +155
- Misses 24752 24778 +26
Partials 138 138
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
N/A
Description 📝
When changing shader file dependencies today you need to manually rebuild changes as webpack watch does not track dependencies for glslify imports. This PR adds a custom webpack loader to track imports.
If this change is not needed feel free to dismiss this PR.
How has this been tested? 🔍
Tested in local development, works.
The loader does not mutate the files so there should be no runtime or build-time changes
Test instructions ℹ️
Start viewer with
yarn build:watchand change a .glsl file (for example updateFragmentColor.glsl) and see that webpack now will auto-rebuild.Checklist ☑️