[CDF-27203] 😎Check unresolved variables#2797
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2797 +/- ##
==========================================
- Coverage 84.57% 84.50% -0.07%
==========================================
Files 447 447
Lines 39552 39629 +77
==========================================
+ Hits 33450 33488 +38
- Misses 6102 6141 +39
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request enhances the build process by tracking metadata such as duration and organization directories, and improving error reporting for unresolved variables and ignored files. The review feedback identifies that unresolved variables in successfully parsed YAML files are currently collected but not stored or displayed, suggesting an update to the BuiltModule data class and display logic to ensure these are visible to the user and prevent silent configuration issues.
…tution # Conflicts: # cognite_toolkit/_cdf_tk/commands/build_v2/build_v2.py # cognite_toolkit/_cdf_tk/commands/build_v2/data_classes/_build.py
# Description Note this is stacked on two branches #2796 , and the branch #2792 -> #2797 . Adds a unit test that builds and deploy the complete orgs. Found a few bugs through the testing: 1. CDF Project not set in `lineage.yaml` when running `cdf build`. 2. Unwrapping build variables were not done correctly for iteration cases. 3. Lineage serialized as relative paths, but requires absolute paths causing failure when loading. 4. Graphql was found in an incorrect way. ## Bump - [ ] Patch - [x] Skip
Description
Check for unresolved variables in build v2, and include ignored and failed files in output.
Bump