fix: Automatically use psycopg2-binary on Apple Silicon #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically select psycopg2-binary for Apple Silicon Macs to avoid compilation issues, while keeping psycopg2 for other platforms.
l0minous
requested review from
a team,
EugeneLightsOn,
ezawadski,
malexw and
tianjing-li
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Automatically selecting psycopg2-binary for Apple Silicon Macs to avoid compilation issues, while keeping psycopg2 for other platforms. Eliminates the need for users to manually replace psycopg2 with psycopg2-binary as mentioned in the troubleshooting section.
Issue: Fixes #883 - Automate psycopg2 to psycopg2-binary Switch for Apple Silicon
Dependencies: None
Testing:
Changes:
pyproject.tomlpoetry.lockwith resolved dependenciespsycopg2-binary(pre-compiled)psycopg2(source compilation)Implementation:
Implemented Poetry's platform-specific dependency markers. Approach automatically selects the correct package based on platform detection, requiring no manual user intervention.