Add PThreads4W to the win-64 msvs-compiled binary package#744
Open
mdealencar wants to merge 2 commits intocoin-or:stable/2.10from
Open
Add PThreads4W to the win-64 msvs-compiled binary package#744mdealencar wants to merge 2 commits intocoin-or:stable/2.10from
mdealencar wants to merge 2 commits intocoin-or:stable/2.10from
Conversation
|
|
Contributor
|
@tkralphs I agree that single-threaded Cbc performs (far) worse than the multi-threaded version. This PR produces a multithreaded Cbc, but only for the windows-msvs workflow, which is used in CI builds and part of released binaries. Are derived products like the conda package using the windows-msvs workflow or similar? I suspect not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
I have modified the windows-msvs workflow to build binary releases with CBC_THREAD enabled. The lack of multi-threading on Windows seems like a major setback for users of CBC on that platform.
The build process uses vcpkg to pull and compile the pthread lib. It seemed to me most straightforward to include the .dll in the distribution, but if you think static linking is the way to go, I can switch to that. Some additional notices are also included to comply with Pthreads4w's Apache-2.0 license.
An artifact is available at https://github.com/mdealencar/Cbc/actions/runs/18375636033 for inspection.
If this PR gets merged, I can adapt it to the master branch as well. Ultimately, I would really like to see this rolling out to the conda package as well.