Skip to content

Conversation

@superadi04
Copy link
Contributor

@superadi04 superadi04 commented Aug 4, 2025

Description

Map chain id resovled from RPC URL to a CDP network identifier (e.g. chain id 8453 resolves to "base"). This will be used to determine if the API should be used for sends, or Web3.py

Builder should be able to pass in their own RPC URL, which will result in tx sends to go to that RPC URL instead of CDP API, and tx waits to also use that RPC URL

If a builder passes an RPC URL for base or base sepolia, the CDP API should still be used for sends, but waits will use their RPC URL

Tests

Checklist

A couple of things to include in your PR for completeness:

  • Updated the typescript README if relevant
  • Updated the python README if relevant
  • Added a changelog entry
  • Added e2e tests if introducing new functionality

@cb-heimdall
Copy link

cb-heimdall commented Aug 4, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link

Review Error for ginalw @ 2025-08-05 00:35:41 UTC
User must have write permissions to review

@coinbase coinbase deleted a comment from ginalw Aug 5, 2025
@superadi04 superadi04 force-pushed the feat/customRPCForSends branch from 7b579a8 to a17c07a Compare August 7, 2025 17:43
@coinbase coinbase deleted a comment from ginalw Aug 8, 2025
@superadi04 superadi04 force-pushed the feat/customRPCForSends branch 4 times, most recently from 10034e1 to 712365b Compare August 11, 2025 15:06
@0xRAG 0xRAG mentioned this pull request Aug 11, 2025
4 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

⚠️ Generated Client Files Have Been Modified

This pull request contains manual changes to generated client files. These files are automatically generated from the OpenAPI specification and should not be edited directly.

Please check the workflow logs for details on which files were modified.

To fix this issue:

  1. Revert any manual changes to files in:
    • typescript/src/openapi-client/generated/
    • python/cdp/openapi_client/
    • go/openapi/
  2. If you need to change the generated code, update the OpenAPI spec (openapi.yaml) instead
  3. Run the generation commands locally to update the generated files

This comment will be automatically removed once the issue is resolved.

@superadi04 superadi04 force-pushed the feat/customRPCForSends branch 4 times, most recently from 7e19e65 to fe43273 Compare August 12, 2025 18:46
@superadi04 superadi04 force-pushed the feat/customRPCForSends branch from 2f6646b to eb71ded Compare August 12, 2025 19:03
@superadi04 superadi04 force-pushed the feat/customRPCForSends branch from 1b6f9a7 to 91f9994 Compare August 13, 2025 14:53
@superadi04 superadi04 force-pushed the feat/customRPCForSends branch from 4ec4091 to 8b91981 Compare August 13, 2025 15:11
@cb-heimdall
Copy link

Review Error for ginalw @ 2025-08-19 23:25:26 UTC
User must have write permissions to review

@0xRAG 0xRAG closed this Jan 8, 2026
@0xRAG 0xRAG deleted the feat/customRPCForSends branch January 8, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants