Skip to content

Comments

fix(DEX2-898): Refactor animation props on web#381

Open
avocado-cb wants to merge 1 commit intocoinbase:masterfrom
avocado-cb:tristyn/reveal-animation-web
Open

fix(DEX2-898): Refactor animation props on web#381
avocado-cb wants to merge 1 commit intocoinbase:masterfrom
avocado-cb:tristyn/reveal-animation-web

Conversation

@avocado-cb
Copy link
Contributor

@avocado-cb avocado-cb commented Feb 9, 2026

What changed? Why?

Chart Enter + Update transition props on Web

Root cause (required for bugfixes)

UI changes

CartesianChart story:

Screen.Recording.2026-02-10.at.6.32.18.AM.mov

AreaChart story:

Screen.Recording.2026-02-10.at.6.34.08.AM.mov
iOS Old iOS New
old screenshot new screenshot
Android Old Android New
old screenshot new screenshot
Web Old Web New
old screenshot new screenshot

Testing

How has it been tested?

  • Unit tests
  • Interaction tests
  • Pseudo State tests
  • Manual - Web
  • Manual - Android (Emulator / Device)
  • Manual - iOS (Emulator / Device)

Testing instructions

Illustrations/Icons Checklist

Required if this PR changes files under packages/illustrations/** or packages/icons/**

  • verified visreg changes with Terran (include link to visreg run/approval)
  • all illustration/icons names have been reviewed by Dom and/or Terran

Change management

type=routine
risk=low
impact=sev5

automerge=true

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 9, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 1
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1
CODEOWNERS 🟡 See below

🟡 CODEOWNERS

Code Owner Status Calculation
ui-systems-eng-team 🟡 0/1
Denominator calculation
Additional CODEOWNERS Requirement
Show calculation
Sum 0
0
From CODEOWNERS 1
Sum 1

@avocado-cb avocado-cb force-pushed the tristyn/reveal-animation-web branch from 6d4a75a to da9dce4 Compare February 9, 2026 22:21
@avocado-cb avocado-cb marked this pull request as ready for review February 9, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants