Conversation
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
| transition={transition} | ||
| transition={transitions?.update ?? transition} | ||
| yAxisId={yAxisId} | ||
| /> |
There was a problem hiding this comment.
Gradient is just a mask of sorts over the path so it has no enter animation, just follows the enter animation of the path.
…e/cds into hunter/chart-transitions
| ? (groupEnterTransition as { duration?: number }).duration | ||
| : accessoryFadeTransitionDuration; | ||
| return { duration: duration ?? accessoryFadeTransitionDuration }; | ||
| }, [groupEnterTransition]); |
There was a problem hiding this comment.
todo: look into this further
| // Track the previous idle state to detect idle<->scrubbing transitions. | ||
| const prevIsIdleRef = useRef(isIdle); | ||
| const isIdleTransition = isIdle !== prevIsIdleRef.current; | ||
| prevIsIdleRef.current = isIdle; |
There was a problem hiding this comment.
Brought over from DefaultScrubberBeacon
| width, | ||
| height, | ||
| borderRadius, | ||
| borderRadius = 4, |
There was a problem hiding this comment.
We already have this set in Bar.tsx but we set here as well for web so wanted to make it consistent.
| i0Shared.value = i0; | ||
| i1Shared.value = i1; | ||
| toSkiaPathShared.value = toSkiaPath; | ||
| }, [i0, i1, toSkiaPath, i0Shared, i1Shared, toSkiaPathShared]); |
There was a problem hiding this comment.
I want to dig into this more on Monday, see if there is a better way to do this.
This allows us to interrupt an in progress animation, and makes things much smoother for charts with lots of changes.
| > & { | ||
| transitions?: { enter?: Transition; update?: Transition }; | ||
| } | ||
| >( |
There was a problem hiding this comment.
This is an internal only component, we are remaking transitions since at this spot we have already converted null instances into instantTransition (a valid transition) so now we should only have undefined or defined transition.
2 participants
What changed? Why?
This PR adds support for chart transitions being customized separately for enter vs update.
UI changes
Coming Wednesday
Testing
Test out new Transitions storybook on mobile and LineChart/AreaChart/BarChart transitions
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false