fix: Prevent <TextInput type="number"> from changing value on scroll#413
Open
maximo-macchi-cb wants to merge 4 commits intomasterfrom
Open
fix: Prevent <TextInput type="number"> from changing value on scroll#413maximo-macchi-cb wants to merge 4 commits intomasterfrom
<TextInput type="number"> from changing value on scroll#413maximo-macchi-cb wants to merge 4 commits intomasterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
sverg-cb
reviewed
Feb 19, 2026
Contributor
sverg-cb
left a comment
There was a problem hiding this comment.
Can you provide a before-and-after of the scroll event on Web?
Otherwise, will stamp after release/changelog commit
Contributor
Author
I didn't post a screenshot or video since that wouldn't really capture the change. But you can use this example to see how the |
3c61be6 to
2b2e8a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This PR updates the behavior of
<TextInput>so that when the input is focused, a user scrolling won't update the value of the input. This is expected behavior in Chrome and Firefox but not Safari.This was reproducible in CDS. Interestingly, I could not reproduce this on a basic
<input type="number">MDN example.This PR's changes accomplishes two things:
Root cause (required for bugfixes)
Native browser behavior adjust the input's value on the
wheelevent. This is not caused by CDS code.UI changesTesting
How has it been tested?
Testing instructions
Verify using the newly added
<TextInput>story with a<TextInput type="number">.Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false