[WIP] Annotates errors from reconciler package with stack trace#297
Open
[WIP] Annotates errors from reconciler package with stack trace#297
Conversation
Pull Request Test Coverage Report for Build 14403
💛 - Coveralls |
2e7cceb to
8688ed3
Compare
8688ed3 to
7c38fba
Compare
septerr
reviewed
Feb 2, 2021
| ErrGetCurrentBlockFailed, | ||
| err, | ||
| ) | ||
| return zeroString, "", 0, errors.Wrapf(ErrGetCurrentBlockFailed, "%v", err) |
Contributor
There was a problem hiding this comment.
I think this should be return zeroString, "", 0, errors.Wrapf(err, "%v: %v", ErrGetCurrentBlockFailed.Error(), err.Error()).
This will make sure we are wrapping the err and getting its stack trace. And we use ErrGetCurrentBlockFailed only for the error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
Previously, we don't have stack trace when it comes to error which makes
rosetta-sdk-goand rosetta-cli a blackbox. It's hard to debug especially when rosetta-cli exited with an error.Solution
This PR annotates errors in package
reconcilerwith stack trace. All behaviors should remain the same. User of this SDK can now print out stack trace throughfmt.Printf("%+v", err)Future Work