Open
Conversation
c0925f2 to
b12608c
Compare
fcc8fe1 to
cd86239
Compare
Contributor
Hello @freddiecoleman - you need to make specifications changes here - https://github.com/coinbase/rosetta-specifications |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently waiting on coinbase/kryptology#48
Motivation
This allows Rosetta users to sign and verify payloads using a
bls12381curve type.It supports both basic and aug with prefix by passing in the relevant signature type.
In order to prepend sign using aug you will need to manually prepend the relevant public key to the payload that is to be signed as the exported interface does not allow an additional argument for the public key.
Solution
Provide an implementation of the Signer interface for
bls12381Open questions
bls12381curve type will not currently be in there. I believe adding the necessary support will require a further PR somewhere else - this should be quite simple?