Subset connections that can be pinned #75
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes proper subsetting the number of connections that can be pinned to cursors. If$N$ is the max pool size and $n$ is the max cache size, we would want $n < N - 1$ : shimming 1 connection for propagating $n$ cursors pinned, then after each round trip check to see if the response has a cursorID. If so, then close the connection and propagate the error: "cursor could not be pinned to connection: maxed out reserve". This ensures that $N-n > 1$ connections are always available.
ErrMaxReserve. That is, if we are at