feat: implement ERC-8004 reputation and fix EVM domain discovery#1186
Open
Ashutosh0x wants to merge 2 commits intocoinbase:mainfrom
Open
feat: implement ERC-8004 reputation and fix EVM domain discovery#1186Ashutosh0x wants to merge 2 commits intocoinbase:mainfrom
Ashutosh0x wants to merge 2 commits intocoinbase:mainfrom
Conversation
This commit adds the ERC-8004 Trustless Agents reputation extension to @x402/extensions, including automated feedback generation and CAIP-220 support. It also enhances @x402/evm with automatic EIP-712 domain discovery to resolve signature verification failures for EIP-3009 tokens like USDC.
|
@Ashutosh0x is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
Author
|
Hi maintainers! I've implemented the ERC-8004 reputation extension and a dynamic EIP-712 domain discovery fix for the EVM facilitator (addressing the USDC 'USD Coin' naming mismatch on Base). All 375+ unit tests passed locally across @x402/extensions and @x402/evm. Could you please approve the CI workflows so we can verify the builds? (Note: I'll be adding a verified commit shortly to resolve the signature requirement). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the ERC-8004 Trustless Agents reputation extension for the x402 protocol and fixes critical signature verification issues on EVM.
Key Changes
1. ERC-8004 Reputation Extension (
@x402/extensions)AgentIdentity(CAIP-10) andReputationInfoschemas using Zod.FeedbackFileSchemasupporting CAIP-220 Task References. This enables agents to link their reputation directly to payment transaction hashes, creating a verifiable proof-of-service.feedbackTool.tswhich automatically extracts payment data from anx402settlement to generate standardized reputation signals.2. EVM Domain Discovery (
@x402/evm)3. Spec & Documentation
specs/schemes/exact/scheme_exact_evm.mdwith warnings about EIP-3009/EOA limitations and recommendations for Permit2.Verification Results