Skip to content
This repository was archived by the owner on Jun 22, 2020. It is now read-only.

Comments

✨implement Tradesprite ticker#1224

Open
Swingcloud wants to merge 3 commits intocoingecko:masterfrom
Swingcloud:feature/tradesprite
Open

✨implement Tradesprite ticker#1224
Swingcloud wants to merge 3 commits intocoingecko:masterfrom
Swingcloud:feature/tradesprite

Conversation

@Swingcloud
Copy link
Contributor

  • What is the purpose of this Pull Request? as title
  • What is the related issue for this Pull Request (if this PR fixes issue, prepend with "Fixes" or "Closes")? closes Implement Tradesprite #1165
  • I have added Specs
  • (If implementing Market Ticker) I have verified that the volume refers to BASE
  • (If implementing Market Ticker) I have verified that the base and target is assigned correctly
  • I have implemented the trade_page_url method that links to the exchange page with the base and target passed in. If not available, enter the root domain of the exchange website.
  • I have verified at least ONE ticker volume matches volume shown on the trading page (use script below)

there are no exchange pages can verify the volume is right or not, even after sign up they need to have KYC approved so I can see the actual volume, so I just skip that.

ticker about XRP_CGC

"XRP-CGC": {
"volume": 16049.905,
"open_price": 9.243,
"moving_stats_minutes": 1440,
"low_price": 8.7712,
"instrument_code": 1312,
"high_price": 10.6905,
"exchange": 11,
"close_price": 10.4967
}

take volume as base volume

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Tradesprite

1 participant