Skip to content
This repository was archived by the owner on Jun 22, 2020. It is now read-only.

Comments

Integrate Tokenmom Exchange#1293

Open
pedrorv0106 wants to merge 13 commits intocoingecko:masterfrom
pedrorv0106:tokenmom
Open

Integrate Tokenmom Exchange#1293
pedrorv0106 wants to merge 13 commits intocoingecko:masterfrom
pedrorv0106:tokenmom

Conversation

@pedrorv0106
Copy link

@pedrorv0106 pedrorv0106 commented Jan 14, 2019

  • What is the purpose of this Pull Request?
  • What is the related issue for this Pull Request (if this PR fixes issue, prepend with "Fixes" or "Closes")?
  • I have added Specs
  • (If implementing Market Ticker) I have verified that the volume refers to BASE
  • (If implementing Market Ticker) I have verified that the base and target is assigned correctly
  • I have implemented the trade_page_url method that links to the exchange page with the base and target passed in. If not available, enter the root domain of the exchange website.
  • I have verified at least ONE ticker volume matches volume shown on the trading page (use script below)
client = Cryptoexchange::Client.new
pairs = client.pairs 'exchange_name'
tickers = pairs.map do |p| client.ticker p end
sorted_tickers = tickers.sort_by do |t| t.volume end.reverse

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant