-
Notifications
You must be signed in to change notification settings - Fork 6
Add category column to support server‑side / backend wallet security checks #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @pad01g! Thank you for submitting your PR— looking good at first glance! The only issue is that uploading the categories before the checks for each individual category are included makes it impossible to assess whether a given category is necessary and applicable to the checklist. I’d suggest submitting everything together in a single PR so all the information is available in one place. Alternatively, you could send one PR per category, making sure to fill in the Category Description section along the way. |
|
@matiassequeira |
|
Sounds good! Feel free to add your first category and its issues in this PR, and we can continue that way. Thank you. |
|
@matiassequeira |
|
Hi @pad01g. Will be taking a look at this during the week. Thanks |
|
Hey @pad01g, sorry for the delay. We reviewed the section you proposed and have a few questions and suggestions.
In parallel, we are also preparing more checks that will fit in this category! |
|
Thanks for feedback! 8.1: Rewritten to state that private keys must be encrypted at rest (never stored in plaintext). 8.3: Split into two separate checks—8.3 (nonce management) and 8.11 (retry mechanisms)—since they are distinct concerns. 8.7: Clarified that this item exists for reconciliation, alerting, and auditability, and added rationale explaining why local timestamps/status are needed even though some data is on-chain. 8.9: Based on practical experience, products are often asked to add new currencies/networks later. If the framework isn’t designed for multi-currency from the start, teams tend to ship ad-hoc changes under time and budget pressure, which can weaken controls. While not a direct control, this is a security-motivated architectural recommendation. |
|
@matiassequeira |
ConsumerWallettag to all existing entries (assuming multiple tags for a single entry is allowed in future)cf. #6
Below are examples of entries that I'm going to add in separate PR once this PR is accepted.
HotWalletHotWalletHotWallet